8000 ReadonlyFieldItem null checks · Issue #10 · hecomi/uREPL · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ReadonlyFieldItem null checks #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zhdiv opened this issue Oct 11, 2017 · 2 comments
Closed

ReadonlyFieldItem null checks #10

zhdiv opened this issue Oct 11, 2017 · 2 comments

Comments

@zhdiv
Copy link
zhdiv commented Oct 11, 2017

Hi,
ReadonlyFieldItem class require additional null check. Something like:
protected set { valueText.text = value==null ? "Null" : value.ToString(); }
Got error with null reference exception if field is unassigned.

And if it possible do not display null message in console at Window.OnSubmit() if result.type == CompileResult.Type.Success

And of course big thanks for asset.
hecomi added a commit that referenced this issue Nov 30, 2017
@hecomi
add null check #10.
7cc4614
@hecomi
Copy link
Owner
hecomi commented Nov 30, 2017 •
edited
Loading

Sorry for my late reply...
I've fixed the null check, thank you for the suggestion.
This fix will be included in the next release.

Regarding the null output, I want to think more about it because uREPL cannot distinguish below scenarios:

$ var obj = GameObject.Find("Cube");
> null
$ object obj;
> null
$ obj; // user wants to check obj is null or not.
> null

@hecomi
Copy link
Owner
hecomi commented Nov 30, 2017

Released:
https://github.com/hecomi/uREPL/releases/tag/v0.5.1

@hecomi hecomi closed this as completed Nov 16, 2018
hecomi added a commit that referenced this issue Aug 18, 2019
@hecomi
add null check #10.
d7d985d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hecomi @zhdiv
0