Fix: Event key filter #1862
Merged
Fix: Event key filter #1862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug related to the event key filter. The changes eliminate an unnecessary allocation of a slice, directly assigning the key values from the request to the options.
- Removed redundant allocation for keys.
- Directly assigns request parameters to opts.Keys.
Comments suppressed due to low confidence (1)
api/v1/server/handlers/v1/events/list.go:56
- [nitpick] Directly assigning the slice streamlines the code; ensure that opts.Keys is not inadvertently modified later, which may affect the original slice in request.Params.Keys.
opts.Keys = *request.Params.Keys
abelanger5
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Event key filter bug
Type of change