Feat: Events Frontend, Redux #1859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mrkaye97
commented
Jun 12, 2025
| @@ -0,0 +1,9 @@ | |||
| -- +goose Up | |||
| -- +goose StatementBegin | |||
| CREATE INDEX v1_events_olap_scope_idx ON v1_events_olap (tenant_id, scope, seen_at DESC) WHERE scope IS NOT NULL; | |||
There was a problem hiding this comment.
partial index to enable filtering by scope + seen at. one note here is we can't create this index concurrently unless we loop over all the partitions, but I figured this was probably fine
abelanger5
requested changes
Jun 12, 2025
|
|
||
| -- name: ListEvents :many | ||
| WITH included_events AS ( | ||
| SELECT DISTINCT e.* |
There was a problem hiding this comment.
seems alright to try this for now
| sc.cancelled_count, | ||
| sc.failed_count | ||
| -- name: ListEventKeys :many | ||
| SELECT DISTINCT key |
There was a problem hiding this comment.
Yeah it's probably alright. We used to have an event key table and use a cached update on it, but we can always do something fancier when we hit problems here
abelanger5
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding back the events frontend + V1-ifying it with some new queries for fetching + filtering events, keys, etc.
TODO:
Type of change