single_backstroke_delete defaults to true #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we should consider ripping out the double backstroke supporting code entirely.
|
Oh yeah 😊 |
| @@ -29,7 +29,7 @@ class AbstractChosen | |||
| @enable_split_word_search = if @options.enable_split_word_search? then @options.enable_split_word_search else true | |||
| @group_search = if @options.group_search? then @options.group_search else true | |||
| @search_contains = @options.search_contains || false | |||
| @single_backstroke_delete = @options.single_backstroke_delete || false | |||
| @single_backstroke_delete = @options.single_backstroke_delete || true | |||
There was a problem hiding this comment.
this code is wrong. false || true is always true. See group_search for the way to configure options defaulting to true
There was a problem hiding this comment.
Oh duh - good catch. On the other hand, this would be a great way to "remove" the feature without removing it.
`@options.single_backstroke_delete || true` is _always_ true.
|
@kenearley @stof can I get a final +1? I've added docs and fixed the default problem. |
| <td>false</td> | ||
| <td>By default, on multiple selects, pressing delete once will highlight the last selection, and pressing again will remove it. Setting this option to <code class="language-javascript">true</code> will remove it on the first press.</td> | ||
| <td>true</td> | ||
| <td>By default, presseing delete/backspace on multiple selects will remove a selected choice. When <code class="language-javascript">false</code>, pressing delete/backspace will highlight the last choice, and a second press deselects it.</td> |
|
Other than the typo, this looks good. |
pfiller
added a commit
that referenced
this pull request
Jul 19, 2013
single_backstroke_delete defaults to true
pfiller
added a commit
that referenced
this pull request
Jul 26, 2013
- CSS Updates #1368, #1371 - Prevent text selection on Chosen #1374 - single_backstroke_delete defaults to true #1375 - No longer expose classes to window context #1389 - Single select value fix #1392 - Remove javascript:void and attr references #1385, #1377 - Disable Chosen on iPhone / iPod and Android mobile devices by default #1388 - Add Destroy Method #1396 - Option to Hide Selected & Disabled Options #1404 - Always clear result highlight #1407 - Replace characters only once #1411 - Document all the things. #1366, #1376, #1383 - Add Gemfile for compass dependency #1373 - Update copyright and license link #1397 - Add @koenpunt as a maintainer #1399 - Add anchors to documentation headers #1395 - Updated stackoverflow instructions #1403
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kenearley @stof @koenpunt @mlettini @starzonmyarmz
Makes single backstroke deleting the default behavior. Presently, you have to hit backspace twice in Chosen to delete an entry in multiselects. This flips it to mirror the behavior of things like Gmail and Facebook.
I think we should consider ripping out the double backstroke supporting code entirely, but we'll see if anyone complains about this before we take that step.
Closes #639