8000 BigEndian test fixes by umlaeute · Pull Request #1625 · hardbyte/python-can · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

BigEndian test fixes #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

BigEndian test fixes #1625

merged 1 commit into from
Jun 30, 2023

Conversation

umlaeute
Copy link
Contributor
  • PCAN_BITRATES are stored in BIGendian, no use to byteswap on littleendian.
  • Also the TPCANChannelInformation expects data in the native byte order

Closes: #1624

@umlaeute
BigEndian test fixes
4d1794f 
PCAN_BITRATES are stored in BIGendian, no use to byteswap on littleendian.
Also the TPCANChannelInformation expects data in the native byte order

Closes: hardbyte#1624
@umlaeute umlaeute force-pushed the bugfix/bigendian-tests branch from 9ead196 to 4d1794f Compare June 29, 2023 10:39
zariiii9003
zariiii9003 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator
@zariiii9003 zariiii9003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@zariiii9003 zariiii9003 merged commit c5d7a7c into hardbyte:develop Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zariiii9003 zariiii9003 zariiii9003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests fail on bigendian
2 participants
@umlaeute @zariiii9003
0