10000 Enable GitHub Actions runners to run tests by karlding · Pull Request #827 · hardbyte/python-can · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable GitHub Actions runners to run tests #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2020

Conversation

karlding
Copy link
Collaborator
@karlding karlding commented May 6, 2020

GitHub announced Actions at GitHub Universe in 2018, however this was
somewhat limited, and support for running CI/CD pipelines was only
released in August 2019. This was in beta for a long time, and finally
has been rolled out to the general public.

This adds a minimal GitHub Actions workflow that runs all the current
tests on a build matrix consisting of {Ubuntu,macOS,Windows} and Python
3.{6,7,8}. This also seems to run much faster than the current Travis CI
pipelines, and actually lets us cover multiple versions on macOS without
a series of hacks.

Unfortunately, the kernel that GitHub Actions uses (5.0.0-1035-azure)
doesn't include the vcan kernel module, so we still need Travis CI to
run SocketCAN tests.

@karlding karlding force-pushed the add_github_actions_runner branch from 610779f to 73b7775 Compare May 6, 2020 07:07
@karlding
Copy link
Collaborator Author
karlding commented May 6, 2020

This adds better coverage on macOS, so I think those changes are pretty reasonable, unless someone has a preference for Azure Pipelines (although it's all Microsoft 😂) or some other provider (Semaphore CI)?

The parts that are potentially controversial are whether we want to migrate off Travis CI for their Linux builds (and potentially releases) and AppVeyor for their Windows builds, and how far we want to go with that, or whether we want to just run these in parallel. I've deferred that from this PR for the most part, but I can also revert the additions of Ubuntu and Windows if we don't want the duplication.

@codecov
Copy link
codecov bot commented May 6, 2020

Codecov Report

Merging #827 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #827   +/-   ##
========================================
  Coverage    70.44%   70.44%           
========================================
  Files           70       70           
  Lines         6835     6835           
========================================
  Hits          4815     4815           
  Misses        2020     2020           

Copy link
Owner
@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the fastest CI platforms wins our business :-)

GitHub announced Actions at GitHub Universe in 2018, however this was
somewhat limited, and support for running CI/CD pipelines was only
released in August 2019. This was in beta for a long time, and finally
has been rolled out to the general public.

This adds a minimal GitHub Actions workflow that runs all the current
tests on a build matrix consisting of {Ubuntu,macOS,Windows} and Python
3.{6,7,8}. This also seems to run much faster than the current Travis CI
pipelines, and actually lets us cover multiple versions on macOS without
a series of hacks.

Unfortunately, the kernel that GitHub Actions uses (5.0.0-1035-azure)
doesn't include the vcan kernel module, so we still need Travis CI to
run SocketCAN tests.
@karlding karlding force-pushed the add_github_actions_runner branch from 73b7775 to 1e57a87 Compare May 28, 2020 07:06
@hardbyte
Copy link
Owner

@karlding if you update this branch it should merge in automatically. I can't update it or push the changes to develop myself without disabling the branch protection which I don't want to do.

@karlding
Copy link
Collaborator Author

Hmm, seems like Mergify/GitHub has some issues when adding a new file that adds additional steps to the workflow..

@hardbyte
Copy link
Owner

@Mergifyio refresh

@mergify
Copy link
Contributor
mergify bot commented Jul 16, 2020

Command refresh: success

@hardbyte hardbyte merged commit 63c60af into hardbyte:develop Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0