Fix crash when outbound connection fails #3456
Conversation
a765afc to
0012135
Compare
|
Hmmm, this might be related to a new [ buggy / suboptimal ] connection startup in node.js. My first thought with this change is that there's a multitude of reasons why a connection might fail, and a static error message will tend to mask the specifics. Perhaps testing err with |
|
Or perhaps something more like this... const errMsg = err.message ? err.message :
err instanceof AggregateError ? err.map(e => e.message).join(', ') :
util.inspect(err { depth: 3 });Testing this code with some of the actual errors see In The Wild[TM] would likely suggest a refinement or two. |
|
Thanks for your excellent input as always @msimerson . I will update the PR . The reason the connection fails is because of the domain has a MX record which just has "." in it and nothing else :/ I guess there is a myriad of ways to put invalid hostnames in DNS . This makes the connection fail and unfortunately haraka keeps crashing . |
In node 22 atleast, network code has started returning AggregateError.
This means that when socket connection fails, err.message is an empty string.
The on('error') handler as a result invoked callback('', null) . Since error
is falsy, code assumes socket is valid and crashes.
Code is changed to always return a error string.
Fixes haraka#3455
0012135 to
61270ac
Compare
In node 22 atleast, network code has started returning AggregateError. This means that when socket connection fails, err.message is an empty string. The on('error') handler as a result invoked callback('', null) . Since error is falsy, code assumes socket is valid and crashes.
Code is changed to always return a error string.
Fixes #3455
Changes proposed in this pull request:
Checklist: