[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip plugins at runtime #2966

Merged
merged 8 commits into from
Sep 12, 2021
Merged

Skip plugins at runtime #2966

merged 8 commits into from
Sep 12, 2021

Conversation

superman20
Copy link
Collaborator

Changes proposed in this pull request:

  • Ability to skip plugins at runtime by adding the name of the plugin into a skip_plugins array in transaction.notes

Checklist:

  • docs updated
  • tests updated
  • Changes updated

msimerson
msimerson previously approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member
@msimerson msimerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@superman20
Copy link
Collaborator Author

Not sure why it says I "dismissed" the review. I did not intentionally do that.

@msimerson
Copy link
Member

Not sure why it says I "dismissed" the review. I did not intentionally do that.

That happens when you add commits to an open PR

@msimerson msimerson merged commit 83637cd into haraka:master Sep 12, 2021
@msimerson msimerson mentioned this pull request Sep 12, 2021
Closed
3 tasks
@superman20 superman20 deleted the skip_plugins branch September 13, 2021 00:01
@superman20 superman20 mentioned this pull request Sep 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimerson msimerson msimerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@superman20 @msimerson