8000 updates for 2.8.18 release by luto · Pull Request #2361 · haraka/Haraka · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

updates for 2.8.18 release #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2018
Merged

updates for 2.8.18 release #2361

merged 2 commits into from
Mar 8, 2018

Conversation

luto
Copy link
Contributor
@luto luto commented Mar 7, 2018 •
edited by msimerson
Loading

I was motivated in #2361 to get a release going, so here we go ;)

@codecov
Copy link
codecov bot commented Mar 7, 2018 •
edited
Loading

Codecov Report

Merging #2361 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2361   +/-   ##
=======================================
  Coverage   59.57%   59.57%           
=======================================
  Files          28       28           
  Lines        6070     6070           
  Branches     1511     1511           
=======================================
  Hits         3616     3616           
  Misses       2454     2454

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b768a...cf48bfc. Read the comment docs.

@luto luto force-pushed the release-2.8.18 branch from 759f388 to c076adc Compare March 7, 2018 10:09
@luto luto force-pushed the release-2.8.18 branch from c076adc to ace8d0e Compare March 7, 2018 10:10
@luto
Copy link
Contributor Author
luto commented Mar 7, 2018

This release is mainly motivated by #2360 (a crash bug).

msimerson
msimerson previously approved these changes Mar 8, 2018
View reviewed changes
Copy link
Member
@msimerson msimerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @luto , if you'll also update the release date in Changes and push to this PR, I'll try to get it released today.

@luto
Copy link
Contributor Author
luto commented Mar 8, 2018

@msimerson done. Thanks! :)

msimerson
msimerson approved these changes Mar 8, 2018
View reviewed changes
Copy link
Member
@msimerson msimerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msimerson msimerson merged commit 130fcb0 into haraka:master Mar 8, 2018
@luto luto deleted the release-2.8.18 branch March 8, 2018 20:51
@msimerson
Copy link
Member 
$ npm publish
+ Haraka@2.8.18

@luto
Copy link
Contributor Author
luto commented Mar 9, 2018

thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimerson msimerson msimerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luto @msimerson
0