8000 require json at spec_helper to fix #532 by gnomex · Pull Request #533 · hashie/hashie · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

require json at spec_helper to fix #532 #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2020
Merged

require json at spec_helper to fix #532 #533

merged 1 commit into from
Oct 5, 2020

Conversation

gnomex
Copy link
Contributor
@gnomex gnomex commented Oct 5, 2020

Fixes, details at #532

Failures:

  1) DashTestDefaultProc to_json behaves correctly with default proc
     Failure/Error: to_hash.to_json(*args)
     
     NoMethodError:
       undefined method `to_json' for {:fields=>[]}:Hash
       Did you mean?  to_s
     # ./lib/hashie/hash.rb:43:in `to_json'
     # ./spec/hashie/dash_spec.rb:61:in `block (2 levels) in <top (required)>'

Finished in 0.18124 seconds (files took 0.31668 seconds to load)
673 examples, 1 failure

Failed examples:

rspec ./spec/hashie/dash_spec.rb:59 # DashTestDefaultProc to_json behaves correctly with default proc

The solution was appointed by @dblock by adding require 'json' to spec_helper.rb

@gnomex gnomex force-pushed the fix-json-specs-error branch from c0492dd to 4759e04 Compare October 5, 2020 13:11
@dblock dblock merged commit 097ad42 into hashie:master Oct 5, 2020
@michaelherold michaelherold 64E3 added the hacktoberfest-accepted Accepted changes for Hacktoberfest label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted changes for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnomex @michaelherold @dblock
0