-
Notifications
You must be signed in to change notification settings - Fork 313
Test with Ruby 2.7 #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test with Ruby 2.7 #524
Conversation
`sudo: false` is deprecated. https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration
Also switch testing jruby-head from EOL Ubuntu to Travis default (xenial).
- rvm: 2.6.6 | ||
dist: bionic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that this was tested on bionic, but is there a specific reason why 2.6 would need to be tested on bionic and the rest not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No specific reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was some reason, but I don't remember what it was 😅
- 2.7 | ||
- 2.6 | ||
- 2.5 | ||
- 2.4 | ||
- 2.3 | ||
- 2.2 | ||
- 2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should pick the latest patch version, so it doesn't have to be micro-managed with every patch release.
.travis.yml
Outdated
- rvm: 2.5.3 | ||
- rvm: 2.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want these to always run with the latest ruby? In this case, 2.7? Same for the integration tests below.
.travis.yml
Outdated
- rvm: jruby-9.0.5.0 | ||
dist: trusty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly part of this PR, but do you wish to continue testing Rubinius? It seems that for testing Rubinius, the only option is to use an EOL Ubuntu.
rubinius/rubinius#3819
https://docs.travis-ci.com/user/languages/ruby/#rubinius
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, wrong line, should be on the rbx-3
line, not jruby
. My bad!
But yeah, do you want to keep testing rbx-3? It seems to fail anyway. We could switch it for testing with TruffleRuby instead, WDYT?
Also I'll try testing jruby 9.0 on xenial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know what we want for Rubinius TBH. I was OK removing it a long time ago.
Report success even before allowed_failures finish
Ok, so this has grown much bigger than I intended. I will gladly roll back any unwanted changes, but I thought it's better to have an actual PR as a proposal than merely discuss possibilities. :) |
Thanks for cleaning this up and adding Ruby 2.7! |
sudo: false
is deprecated.https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration