make sure we continue to default to Megabytes for qemu disk size to p… #8438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revent backwards incompatabilities.
azr
reviewed
Dec 4, 2019
Comment on lines
+152
to
157
| < 8000 /td> | // The size in bytes of the hard disk of the VM. Suffix with the first | |
| // letter of common byte types. Use "k" or "K" for kilobytes, "M" for | ||
| // megabytes, G for gigabytes, and T for terabytes. If no value is provided | ||
| // for disk_size, Packer uses a default of `40960M` (40 GB). If a disk_size | ||
| // number is provided with no units, Packer will default to Megabytes. | ||
| DiskSize string `mapstructure:"disk_size" required:"false"` |
There was a problem hiding this comment.
I was about to say that I was amazed that there is not open source package that does this like the time pkg. But then I found this: https://github.com/docker/go-units/blob/master/size.go
There was a problem hiding this comment.
This is basically a direct passthrough to the qemu-img command call, so I think using an intermediary library would be more work than it's worth.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v1.4.5 we defaulted to megabytes for the size of a qemu disk. Keep this default, if the value being read does not have units.
Addresses concerns raised in #5969 (comment)