Add role option for S3 URLs #275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for specifying an IAM role that is assumed before making S3
requests. Beforehand this was only possible when using profiles which
required local files for configuration.
Now it is possible to specify such an IAM role in the URL, thereby
supporting settings where a IAM role needs to be assumed for data
access (e.g. cross-account).
Example of usage:
s3::bucket.s3.amazonaws.com/file?aws_iam_role=some-role-arn
|
Any chance to get some feedback on this? |
|
Any chance to get someone to look at this? |
|
ping? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for specifying an IAM role that is assumed before making S3
requests. Beforehand this was only possible when using profiles which
required local files for configuration.
Now it is possible to specify such an IAM role in the URL, thereby
supporting settings where a IAM role needs to be assumed for data
access (e.g. cross-account).
Example of usage:
s3::bucket.s3.amazonaws.com/file?aws_iam_role=some-role-arn
This currently only has a negative test case as I do not have access to the used AWS account. If someone could help me with details to write a positive test case as well, that would be much appreciated.