8000 VAULT-35530: Add Audit Metrics by aslamovamir · Pull Request #30643 · hashicorp/vault · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

VAULT-35530: Add Audit Metrics #30643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

VAULT-35530: Add Audit Metrics #30643

wants to merge 8 commits into from

Conversation

aslamovamir
Copy link
Contributor
@aslamovamir aslamovamir commented May 15, 2025 •
edited
Loading

Description

What does this PR do?
This PR adds audit metrics related to count of audit devices by type and of audit exclusion stanzas.

Jira: https://hashicorp.atlassian.net/browse/VAULT-35530
ENT PR: https://github.com/hashicorp/vault-enterprise/pull/8076

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 15, 2025
@aslamovamir aslamovamir marked this pull request as ready for review May 15, 2025 18:52
@aslamovamir aslamovamir requested a review from a team as a code owner May 15, 2025 18:52
@aslamovamir aslamovamir requested a review from cinthiaconti May 15, 2025 18:52
@github-actions GitHub Actions
Copy link
github-actions bot commented May 15, 2025 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link
github-actions bot commented May 15, 2025 •
edited
Loading

Build Results:
All builds succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cinthiaconti cinthiaconti Awaiting requested review from cinthiaconti cinthiaconti is a code owner automatically assigned from hashicorp/vault

@VioletHynes VioletHynes Awaiting requested review from VioletHynes

@divyaac divyaac Awaiting requested review from divyaac

@akshya96 akshya96 Awaiting requested review from akshya96

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aslamovamir
0