8000 [UI] Update vault-reporting addon by j--w · Pull Request #30632 · hashicorp/vault · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ vault Public

[UI] Update vault-reporting addon #30632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UI] Update vault-reporting addon #30632

wants to merge 1 commit into from
+19 −8

Conversation

j--w
Copy link
Contributor
@j--w j--w commented May 14, 2025 •
edited
Loading

Description

These updates include a change to hide the replication status card link for HVD clusters as that is managed in HCP.

Note: Please do not review the generated dist files in vault-reporting. This should be treated effectively as a package update. To view the changeset included in this PR it's better to look at the source changes in the vault-reporting addon.

Regular enterprise cluster:
image

HVD cluster:
image

How to test

This is how I've been approximating HVD locally:

  1. Add administrative_namespace_path = "admin/" to config
  2. Build vault-enterprise from main branch
  3. Set VAULT_CLOUD_ADMIN_NAMESPACE=1 and run vault
  4. Create an admin namespace
  5. Run the UI on this branch

After doing that and visiting the vault usage page you should see that the replicaiton status card does not render a link to the replication page.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: 8000 If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@j--w j--w added this to the 1.20.0-rc milestone May 14, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 14, 2025
@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@j--w j--w marked this pull request as ready for review May 15, 2025 18:18
@j--w j--w requested a review from a team as a code owner May 15, 2025 18:18
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Milestone
1.20.0-rc
Development

Successfully merging this pull request may close these issues.
1 participant
@j--w
0