8000 write known issues for follower nodes failure to extract ent plugins by thyton · Pull Request #30628 · hashicorp/vault · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

write known issues for follower nodes failure to extract ent plugins #30628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 16, 2025
Merged

write known issues for follower nodes failure to extract ent plugins #30628

merged 4 commits into from
May 16, 2025

Conversation

thyton
Copy link
Contributor
@thyton thyton commented May 14, 2025 •
edited
Loading

Description

What does this PR do?
Adds known issue docs for follower nodes failure to extract enterprise plugins v1.16.17 - v1.16.20, v1.17.13 - v1.17.16,
v1.18.6 - v1.18.9, v1.19.0 - v1.19.3.

Adds recommendation:

  • Workaround for the affected versions
  • Or upgrade to newer versions for the fix

Updates the affected versions to fixed versions and recommendation to upgrade to newer versions for Azure auth known issues that was documented in #30373.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@thyton thyton requested review from a team as code owners May 14, 2025 20:17
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 14, 2025
@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

@thyton thyton requested a review from schavis May 14, 2025 20:21
@thyton thyton added the docs label May 14, 2025
@thyton thyton added this to the 1.19.4 milestone May 14, 2025
@thyton
Copy link
Contributor Author
thyton commented May 14, 2025

Hi @schavis, I see you did a lot of the refactor for the plugin docs. I'd like to ensure the PR change fits into your documentation design. I'd appreciate your feedback on the PR!

@thyton thyton changed the title write known issues for follower nodes failed to extract ent plugins write known issues for follower nodes failure to extract ent plugins May 14, 2025
helenfufu
helenfufu reviewed May 14, 2025
View reviewed changes
Copy link
Contributor
@helenfufu helenfufu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I like the linked references between the recommendation/workaround for the older versions and the standard registration docs for the later versions. And thanks again for the Azure doc update 🙌

Otherwise just had a couple comments about changing the backslashes to forward slashes for the directory strings.

website/content/docs/plugins/register.mdx
Comment on lines +33 to +34
- **For other plugins, you must have the plugin binary saved to the
location set in `plugin_directory`**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not really a review comment but commenting here so I can find the reference again somewhat quickly.)

Note to self: I should update this documentation as part of VAULT-34905 when we start supporting the extracted artifact with metadata verification for CE plugins.

thyton and others added 2 commits May 15, 2025 09:09
@thyton @helenfufu
Update website/content/docs/commands/plugin/register.mdx
1a12935 
Co-authored-by: helenfufu <25168806+helenfufu@users.noreply.github.com>
@thyton @helenfufu
Update website/content/docs/plugins/register.mdx
bf766a3 
Co-authored-by: helenfufu <25168806+helenfufu@users.noreply.github.com>
@thyton thyton merged commit 10dafbd into main May 16, 2025
39 checks passed
@thyton thyton deleted the thyton/VAULT-36151/doc-known-issue-ent-plugin-artifacts-extract branch May 16, 2025 20:01
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helenfufu helenfufu helenfufu left review comments

@yhyakuna yhyakuna yhyakuna approved these changes

@JMGoldsmith JMGoldsmith Awaiting requested review from JMGoldsmith JMGoldsmith is a code owner automatically assigned from hashicorp/vault-customer-engineering

@anwittin anwittin Awaiting requested review from anwittin anwittin is a code owner automatically assigned from hashicorp/vault-customer-engineering

@schavis schavis Awaiting requested review from schavis

Assignees
No one assigned
Labels
backport/1.19.x docs hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Milestone
1.19.4
Development

Successfully merging this pull request may close these issues.
3 participants
@thyton @yhyakuna @helenfufu
0