8000 Add fixes for processing InTune SCEP messages within our PKCS7 library by stevendpclark · Pull Request #30595 · hashicorp/vault · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add fixes for processing InTune SCEP messages within our PKCS7 library #30595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Add fixes for processing InTune SCEP messages within our PKCS7 library #30595

merged 1 commit into from
May 14, 2025
+307 −4

Conversation

stevendpclark
Copy link
Contributor

Description

Add two fixes related to processing SCEP messages sent from Windows InTune clients.

  1. Add support for decrypting the content key using RSA-OAEP instead of PKCS1v15.
  2. Add a workaround for parsing the embedded certificate that has a authority key identifier extension marked as critical, which the standard x509 Go library explicitly forbids.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@stevendpclark stevendpclark added this to the 1.20.0-rc milestone May 13, 2025
@stevendpclark stevendpclark requested a review from a team May 13, 2025 16:48
@stevendpclark stevendpclark self-assigned this May 13, 2025
@stevendpclark stevendpclark requested a review from a team as a code owner May 13, 2025 16:48
@stevendpclark stevendpclark requested a review from j--w May 13, 2025 16:48
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 13, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented May 13, 2025 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

github-advanced-security[bot]
github-advanced-security bot found potential problems May 13, 2025
View reviewed changes
victorr
victorr approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor
@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty neat. 👍

helper/pkcs7/x509_workaround.go
CRLDistributionPoints: ctxCert.CRLDistributionPoints,
PolicyIdentifiers: convertAsn1ObjectIdentifiers(ctxCert.PolicyIdentifiers),
// Newer fields that are not in Google Transparency
Policies: nil,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any risk of callers expecting any of these fields to be set correctly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all related to the Go 1.24 Policy extension parsing I believe, so for our use case at least no.

@stevendpclark stevendpclark merged commit 1551d69 into main May 14, 2025
142 of 145 checks passed
@stevendpclark stevendpclark deleted the stevendpclark/vault-33779-add-pkcs7-intune-extension-workaround branch May 14, 2025 12:25
drivera258 pushed a commit that referenced this pull request May 14, 2025
@stevendpclark @drivera258
Add fixes for processing InTune SCEP messages within our PKCS7 library (
ce01b08 
#30595)
drivera258 pushed a commit that referenced this pull request May 14, 2025
@stevendpclark @drivera258
Add fixes for processing InTune SCEP messages within our PKCS7 library (
4929750 
#30595)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorr victorr victorr approved these changes

@j--w j--w Awaiting requested review from j--w j--w is a code owner automatically assigned from hashicorp/vault

Assignees

@stevendpclark stevendpclark

Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Milestone
1.20.0-rc
Development

Successfully merging this pull request may close these issues.
2 participants
@stevendpclark @victorr
0