8000 VAULT-34848: Deprecate sys/internal/counters/tokens endpoint by aslamovamir · Pull Request #30561 · hashicorp/vault · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

VAULT-34848: Deprecate sys/internal/counters/tokens endpoint #30561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 13, 2025
Merged

VAULT-34848: Deprecate sys/internal/counters/tokens endpoint #30561 < 8000 /h1>
merged 4 commits into from
May 13, 2025

Conversation

aslamovamir
Copy link
Contributor
@aslamovamir aslamovamir commented May 8, 2025 •
edited
Loading

Description

What does this PR do?
Removed the /sys/internal/counters/tokens endpoint. This internal API is now deprecated and no longer available.
Jira ticket: https://hashicorp.atlassian.net/browse/VAULT-34849
ENT PR: https://github.com/hashicorp/vault-enterprise/pull/8039

Testing:
Before the changes:
Screenshot 2025-05-08 at 6 44 30 PM
Screenshot 2025-05-08 at 6 45 19 PM

After the changes:
Screenshot 2025-05-08 at 6 28 37 PM

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 8, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented May 8, 2025

CI Results:
All Go tests succeeded! ✅

@aslamovamir aslamovamir marked this pull request as ready for review May 8, 2025 22:32
@aslamovamir aslamovamir requested a review from a team as a code owner May 8, 2025 22:32
@aslamovamir aslamovamir requested review from armon, divyaac and akshya96 May 8, 2025 22:32
@github-actions GitHub Actions
Copy link
github-actions bot commented May 8, 2025

Build Results:
All builds succeeded! ✅

akshya96
akshya96 previously approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor
@akshya96 akshya96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

divyaac
divyaac requested changes May 12, 2025
View reviewed changes
@aslamovamir aslamovamir requested a review from divyaac May 12, 2025 18:37
@aslamovamir aslamovamir merged commit 8c01b35 into main May 13, 2025
92 checks passed
@aslamovamir aslamovamir deleted the aslamovamir/vault-34849-deprecate-internal-tokens-api branch May 13, 2025 14:07
Monkeychip pushed a commit that referenced this pull request May 13, 2025
@aslamovamir @Monkeychip
VAULT-34848: Deprecate sys/internal/counters/tokens endpoint (#30561)
3999772 
* deprecate sys/internal/counters/tokens endpoint

* add changelog entree

* update changelog as suggested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyaac divyaac divyaac approved these changes

@akshya96 akshya96 akshya96 left review comments

@armon armon Awaiting requested review from armon armon is a code owner automatically assigned from hashicorp/vault

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aslamovamir @divyaac @akshya96
0