8000 VAULT-35081: Extract query parameters for snapshot read/recover by miagilepner · Pull Request #30567 · hashicorp/vault · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

VAULT-35081: Extract query parameters for snapshot read/recover #30567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 12, 2025
Merged

VAULT-35081: Extract query parameters for snapshot read/recover #30567

merged 4 commits into from
May 12, 2025

Conversation

miagilepner
Copy link
Collaborator
@miagilepner miagilepner commented May 9, 2025 •
edited
Loading

Description

This PR adds support for extracting two query parameters:

  • recover_snapshot_id (can be specified with PUT, POST)
  • read_snapshot_id (can be specified with GET, LIST)

If the query parameter exists for a request with the correct HTTP verb, then request.RequiredSnapshotID is set to the query parameter value.

These requests are also always forwarded to the active node, rather than being served on a perf standby.
RFC: https://go.hashi.co/prd/vlt-045

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@miagilepner miagilepner added this to the 1.20.0-rc milestone May 9, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 9, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented May 9, 2025 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@miagilepner miagilepner marked this pull request as ready for review May 12, 2025 08:41
@miagilepner miagilepner requested a review from a team as a code owner May 12, 2025 08:41
@github-actions GitHub Actions
Copy link
github-actions bot commented May 12, 2025 •
edited
Loading

Build Results:
All builds succeeded! ✅

kubawi
kubawi approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor
@kubawi kubawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miagilepner miagilepner enabled auto-merge (squash) May 12, 2025 11:59
@miagilepner miagilepner merged commit 7b3f80d into main May 12, 2025
92 checks passed
@miagilepner miagilepner deleted the miagilepner/VAULT-35081-handler-logic-snapshot-read branch May 12, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubawi kubawi kubawi approved these changes

@guygrigsby guygrigsby Awaiting requested review from guygrigsby

@biazmoreira biazmoreira Awaiting requested review from biazmoreira

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Milestone
1.20.0-rc
Development

Successfully merging this pull request may close these issues.
2 participants
@miagilepner @kubawi
0