[VAULT-34808] UI: move the radio block in FormField under the HDS block
#30555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
084e541 to
665a654
Compare
|
CI Results: |
0dffe69 to
d245fa1
Compare
2 tasks
e406bb1 to
6664da0
Compare
793c5d3 to
914d1a6
Compare
174a9af to
810c1e6
Compare
914d1a6 to
509a832
Compare
810c1e6 to
5d3f5c3
Compare
9aaea0b to
d2a44e6
Compare
5d3f5c3 to
f3e4d6b
Compare
6 tasks
d2a44e6 to
bbf755a
Compare
f3e4d6b to
5e71766
Compare
|
@Monkeychip can you (or someone else) have a look at this other PR? It is built on top of #30345, so we have a "standard" for how to write the tests for the form fields migrated to HDS. Let me also know if you want me to take screenshots of before/after the changes for some of the pages. |
|
Build Results: |
didoo
commented
May 13, 2025
| {{#if this.hasRadioSubText}} | ||
| <F.HelperText data-test-help-text={{val.subText}}>{{val.subText}}</F.HelperText> | ||
| {{else if this.hasRadioHelpText}} | ||
| <F.HelperText data-test-help-text={{val.helpText}}>{{val.helpText}}</F.HelperText> |
There was a problem hiding this comment.
In this case the @helpText instead of being hidden behind a tooltip, is exposed as field's helper text (better for accessibility). See thread for context: https://hashicorp.slack.com/archives/C05DGFEBCP2/p1746701234173239
Monkeychip
reviewed
May 13, 2025
| @@ -205,6 +205,12 @@ export default class FormFieldComponent extends Component { | |||
| this.setAndBroadcast(updatedValue); | |||
| } | |||
| @action | |||
| setAndBroadcastRadio(item) { | |||
| // we want to read the original value instead of `event.target.value` so we have `false` (boolean) and not `"false"` (string) | |||
There was a problem hiding this comment.
thank you for the comment!
Base automatically changed from
VAULT-34671/improve-form-field-test-coverage_VAULT-34873
to
main
May 13, 2025 19:59
2662e40 to
128ee85
Compare
|
@Monkeychip I had to rebase to fix a couple of conflicts, can you re-approve? thanks |
128ee85 to
f245ad6
Compare
f245ad6 to
95cad10
Compare
Monkeychip
approved these changes
May 14, 2025
drivera258
pushed a commit
that referenced
this pull request
May 14, 2025
… block (#30555) * [UI] moved template logic for `radio` editType in `FormField` under the `isHdsField` block (#34742) * [UI] added integration tests for `FormField` with editType=‘radio’ (#34742) * [UI] fix broken tests (#34742)
drivera258
pushed a commit
that referenced
this pull request
May 14, 2025
… block (#30555) * [UI] moved template logic for `radio` editType in `FormField` under the `isHdsField` block (#34742) * [UI] added integration tests for `FormField` with editType=‘radio’ (#34742) * [UI] fix broken tests (#34742)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
isHdsFormFieldofFormFieldto include theeditType === 'radio'use caseeditType === 'radio'inFormFieldunder theisHdsFieldblockonChangeargument, I had to add a newsetAndBroadcastRadioaction in the controllerJira ticket: https://hashicorp.atlassian.net/browse/VAULT-34808
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.