Attempt to make the compiler thread-safe. #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I clawed back some of the performance with a move constructor and assignment operator to reduce the number of times we incref/decref. Now the slowdown is in the noise. |
|
If the slowdown is in the noise, I don't see why we shouldn't do this. The changes look good to me. |
8000
|
I'm seeing a 5% compile-time slowdown again on other apps (the fft compilation). @zvookin, do you have an opinion on whether thread-safety of the compiler is worth a 5% slowdown? We could also conditionalize it on a preprocessor define. You can turn on and off the part that hurts performance by switching RefCount between an |
|
Per offline discussion, merging this. |
abadams
added a commit
that referenced
this pull request
Mar 1, 2016
Attempt to make the compiler thread-safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe these are the changes required to make the whole compiler thread-safe. Unfortunately it comes with a 5% slowdown (in compile times) due to the atomic increment/decrement in the shared pointer.
Is a thread-safe compiler worth a 5% slowdown?