Typed create buffer_t #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2015 18:23
size to an Expr where the Type itself is the meaningful information. This encodes more complete type information which is needed immediately in the JavaScript branch and will be used everywhere when we add complete type info to buffer_t. I chose to replace the elem_size argument isntead of add a new one as the information is redundant and this is a simpler code change. I cannot think of a valid situation were elem_size should be allowed to disagree with the byte size of the Type. In fact, I can see an argument for elminating elem_size when the type info is added to buffer_t.
|
All tests pass except introspection and one of the float16 ones, neither of which seem to be related to this change and probably have to do witht eh specific tool chain I'm using. (The float16 failure is due to some linker/debug info thing I think.) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the second argument to create_buffer_t intrinsics from a byte
size to an Expr where the Type itself is the meaningful
information. This encodes more complete type information which is
needed immediately in the JavaScript branch and will be used
everywhere when we add complete type info to buffer_t.
I chose to replace the elem_size argument isntead of add a new one as
the information is redundant and this is a simpler code change. I
cannot think of a valid situation were elem_size should be allowed to
disagree with the byte size of the Type. In fact, I can see an
argument for elminating elem_size when the type info is added to
buffer_t.