8000 Fails to build with Xcode 9 on macOS 10.13 · Issue #35 · halo/macosvpn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fails to build with Xcode 9 on macOS 10.13 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an 8000 issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fxcoudert opened this issue Sep 23, 2017 · 4 comments
Closed

Fails to build with Xcode 9 on macOS 10.13 #35

fxcoudert opened this issue Sep 23, 2017 · 4 comments

Comments

@fxcoudert
Copy link 
** BUILD FAILED **
The following build commands failed:
	CompileC build/macosvpn.build/Release/macosvpn.build/Objects-normal/x86_64/DDOSLogger.o macosvpn/Vendor/CocoaLumberjack/DDOSLogger.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full logs there: https://gist.github.com/4dd9dd05a6147e9608c1ea548379e365

/tmp/macosvpn-20170924-40656-41s3ia/macosvpn-0.3.2/macosvpn/Vendor/CocoaLumberjack/DDOSLogger.m:58:17: error: static_assert failed "format argument mus
t be a string constant"
                os_log_error(OS_LOG_DEFAULT, msg);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In module 'os' imported from /tmp/macosvpn-20170924-40656-41s3ia/macosvpn-0.3.2/macosvpn/Vendor/CocoaLumberjack/DDOSLogger.m:17:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/os/log.h:319:9: note: expanded from mac
ro 'os_log_error'
        os_log_with_type(log, OS_LOG_TYPE_ERROR, format, ##__VA_ARGS__)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/os/log.h:475:5: note: expanded from mac
ro 'os_log_with_type'
    _Static_assert(__builtin_constant_p(format), "format argument must be a string constant"); \
    ^              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/macosvpn-20170924-40656-41s3ia/macosvpn-0.3.2/macosvpn/Vendor/CocoaLumberjack/DDOSLogger.m:62:17: error: static_assert failed "format argument mus
t be a string constant"
                os_log_info(OS_LOG_DEFAULT, msg);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In module 'os' imported from /tmp/macosvpn-20170924-40656-41s3ia/macosvpn-0.3.2/macosvpn/Vendor/CocoaLumberjack/DDOSLogger.m:17:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/os/log.h:247:9: note: expanded from mac
ro 'os_log_info'
        os_log_with_type(log, OS_LOG_TYPE_INFO, format, ##__VA_ARGS__)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/os/log.h:475:5: note: expanded from mac
ro 'os_log_with_type'
    _Static_assert(__builtin_constant_p(format), "format argument must be a string constant"); \
    ^              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/macosvpn-20170924-40656-41s3ia/macosvpn-0.3.2/macosvpn/Vendor/CocoaLumberjack/DDOSLogger.m:67:17: error: static_assert failed "format argument mus
t be a string constant"
                os_log_debug(OS_LOG_DEFAULT, msg);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In module 'os' imported from /tmp/macosvpn-20170924-40656-41s3ia/macosvpn-0.3.2/macosvpn/Vendor/CocoaLumberjack/DDOSLogger.m:17:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/os/log.h:277:9: note: expanded from mac
ro 'os_log_debug'
        os_log_with_type(log, OS_LOG_TYPE_DEBUG, format, ##__VA_ARGS__)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/os/log.h:475:5: note: expanded from macro 'os_log_with_type'
    _Static_assert(__builtin_constant_p(format), "format argument must be a string constant"); \
    ^              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
@fxcoudert fxcoudert mentioned this issue Sep 24, 2017
Closed
85 tasks
halo added a commit that referenced this issue Sep 29, 2017
@halo
Pulled upstream DDOSLogger #35
69f33b0
@halo
Copy link
Owner
halo commented Sep 29, 2017

Hi! Sorry for getting back at you so late. The reason is that I thought the email notification of this issue was created by some continuous integration bot to tell me that High Sierra is failing. I didn't realize it was an actual human being asking me to fix it :D

Which I think I did. The tests are passing locally, I'm still wa 8000 iting for Travis and am going to tag this release 0.3.3 as soon as I know for sure that it works.

@halo
Copy link
Owner
halo commented Sep 30, 2017

@fxcoudert Travis passing. Please give this release a try if you have High Sierra already: https://github.com/halo/macosvpn/releases/tag/0.3.3

@fxcoudert fxcoudert mentioned this issue Oct 5, 2017
Closed
@fxcoudert
Copy link
Author

@halo it builds fine, on all macOS versions (10.11 and later). Right now, the version is marked as "pre-release", and so we can't update to it just yet. Can you make it an official release?

@halo
Copy link
Owner
halo commented Oct 6, 2017

Said and done.

Thank you indeed for your help.

@halo halo closed this as completed Oct 6, 2017
scottk212 added a commit to scottk212/macosvpn that referenced this issue Oct 18, 2019
@scottk212
Update forked repository master branch (#1)
f125d63 
* Updated for Xcode 8
Still using Swift 2.3 though

* Travis: Use XCode 8

* Sierra compatibility halo#21
I took the chance and converted VPNServiceCreator to Swift

* Version bump 0.2.1 -> 0.3.0 halo#21

* Updated changelog halo#21

* bundle update halo#21

* Extracted CFArray enumeration halo#21

* XCode project update halo#21

* PPP keychain items didn't change name, only cisco did Closes halo#23

* Prevented an Xcode warning halo#21

* Unified exit codes in enumerator

* Updated Xcode project halo#21

* Added Sierra to README

* Trying to cleanup double-XAUTH interpolation halo#23
This appears to work on Sierra now. Reportedly on El Capitan as well

* Version bump 0.3.0 -> 0.3.1

* Making bundler on Travis happy

* Updated download links on README

* Added exit codes to CHANGELOG for 0.3.1

* Ruby on Travis 2.2.4 -> 2.2.5
Some gems depend on it

* Xcode automated Swift upgrade

* Do not activate code optimization, it will break functionality
See halo#13

* Upgraded PrettyColors vendor library halo#30

* Updated CocoaLumberjack halo#30

* Fixed a compiler warning halo#30

* Explicitly unwrap all interpolated optional strings

* Updated changelog halo#30

* Added disconnect on switch/logout flags halo#33

* Added disconnect on switch/logout to help halo#33

* How about not breaking code halo#33

* Added specs halo#33

* Version bump 0.3.1 -> 0.3.2 halo#33

* Making rubocop happy halo#33
I know I cheated ;)

* Pulled upstream DDOSLogger halo#35

* Updated Xcode 8.3 -> 9.0

* Fixed compiler warnings
Simply by updating the upstream classes

* Version bump 0.3.2 -> 0.3.3

* Travis tests Xcode 8+9

* Added changelog for 0.3.3

* Clarified macOS version requirement in README [skip ci]

* CI: Try only xcode 9

* Added delete subcommand halo#36

* Bundle update
Github noted a security vulnerability in rubocop:
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-8418

* Target ruby 2.4 in tests

* Rubocop --auto-correct

* Relax ruby version in Gemfile for Travis

* Use default Travis ruby version

* Rubocop happiness

* Compare same datatypes only halo#37
This breaks on compiling on El Capitan

* Travis runs Xcode 8 as well halo#37
@scottk212 scottk212 mentioned this issue Oct 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@halo @fxcoudert
0