Tags migrate #7755

awu0403 · 2025-04-22T02:02:35Z

No description provided.

handle exist tag name

JoinTyang · 2025-05-06T07:58:48Z

seahub/repo_metadata/apis.py

+            FROM `{METADATA_TABLE.name}` 
+            WHERE `{METADATA_TABLE.columns.is_dir.name}` = False
+            AND `{METADATA_TABLE.columns.file_name.name}` IN ({filenames_str})
+            AND `{METADATA_TABLE.columns.parent_dir.name}` IN ({dir_paths_str})


这样查不准确

JoinTyang · 2025-05-07T08:10:14Z

seahub/repo_metadata/apis.py

+            return api_error(status.HTTP_403_FORBIDDEN, error_msg)
+
+        try:
+            source_tags_info, file_paths_set, tagged_files = self._get_source_tags_info(repo_id)


可以把查询旧的放到主函数中，组织需要迁移的数据结构用一个函数

JoinTyang · 2025-05-07T08:25:52Z

seahub/repo_metadata/apis.py

+            record_id = record.get(METADATA_TABLE.columns.id.name)
+
+            file_path = posixpath.join(parent_dir, file_name)
+            file_to_record_map[file_path] = record_id


metadata记录的处理没必要放这里吧，这个里面也没用到啊

JoinTyang · 2025-05-07T08:40:15Z

seahub/repo_metadata/apis.py

+            file_path = posixpath.join(parent_dir, file_name)
+            file_to_record_map[file_path] = record_id
+
+        tags_data = []  # [{name: '', color: ''}]


这里不如叫 old_tags，source_tags_info 改成 old_tags_info

JoinTyang · 2025-05-07T08:47:36Z

seahub/repo_metadata/apis.py

+            file_path = posixpath.join(parent_dir, file_name)
+            file_to_record_map[file_path] = record_id
+
+        tags_data = []  # [{id: '', name: '', color: ''}]


变量名改一下，改成 old_tags，source_tags_info 也改成 old_tags_info 吧

JoinTyang · 2025-05-07T08:51:56Z

seahub/repo_metadata/apis.py

+                    TAGS_TABLE.columns.name.name: tag_name,
+                    TAGS_TABLE.columns.color.name: tag_color
+                })
+            tags_to_create_info = tags_data


这部分可以简化吧

JoinTyang · 2025-05-07T08:53:55Z

seahub/repo_metadata/apis.py

+
+        try:
+            # preare tags data
+            tags_to_create, tags_to_create_info, tags_not_to_create, file_to_record_map = \


变量名要改一下，缺少区分度

JoinTyang · 2025-05-08T02:43:33Z

seahub/repo_metadata/apis.py

+                                  'color': repo_tag.color,

            
+                    'file_paths': []
+                }
+        return old_tags_info, file_paths_set


找old_tag 在 repo_tags 表中就够了吧，找到后添加到metadata的tag表中，不需要和file_tag一起处理，
下面的_prepare_tags_data_for_creation中也是

JoinTyang · 2025-05-08T03:33:13Z

seahub/repo_metadata/apis.py

+
+        # create record id to tag id mapping
+        record_to_tags_map = {}  # {record_id: [tag_id1, tag_id2]}
+        for tag_id, tag_info in destination_tags_info.items():


destination_tags_info 改成 {path: {tag_id, ..}} 这种形式，这里的循环就不需要了

JoinTyang · 2025-05-08T03:41:26Z

seahub/repo_metadata/apis.py

+        metadata_server_api = MetadataServerAPI(repo_id, request.user.username)
+        try:
+            # query records
+            metadata_records = self._get_metadata_records(metadata_server_api, file_paths_set, METADATA_TABLE)


这个在最后才会用到，没必要在这里就查出来，可以放到用到的地方之前调用就可以了

JoinTyang · 2025-05-08T03:45:52Z

seahub/repo_metadata/apis.py

+                new_tag_ids = response.get('row_ids', [])
+                for idx, tag in enumerate(tags_to_create):
+                    new_tag_id = new_tag_ids[idx]
+                    file_paths = old_tags_info[tags_details[idx].get(TAGS_TABLE.columns.id.name)].get('file_paths')


old_tags_info 改成 {old_tag_name: {path}, } 这种形式，使用更方便吧

JoinTyang · 2025-05-08T04:01:49Z

seahub/repo_metadata/apis.py

+                        'file_paths': file_paths
+                    }
+            if exist_tags:
+                for tag in exist_tags:


不需要加 if , exist_tags 这个是不是不需要，即使metadata的tag中已经有了这个tag也没不需要找出来吧，只要把已存在的metadata的tag_id 和迁移过来的合并就行了吧，有重复的通过集合也会自动去重了

JoinTyang · 2025-05-08T09:12:12Z

seahub/repo_metadata/apis.py

+        tags_to_create = [] # [{name:'', color:''}, ...]
+        old_exist_tags = {} # {old_tag_name:id,} Existing tags
+
+        for tag_data in old_tags:


这里直接遍历 repo_tags 不行吗？为什么上面遍历repo_tags 后生成old_tags 再遍历old_tags呢

JoinTyang · 2025-05-08T09:39:23Z

seahub/repo_metadata/apis.py

+            if tag_name in existing_tag_map:
+                # Tag already exists, no need to create it
+                new_tag_id = existing_tag_map.get(tag_name)
+                old_exist_tags[tag_name] = new_tag_id


改成 old_tag_name_to_metadata_tag_id

JoinTyang · 2025-05-08T09:40:57Z

seahub/repo_metadata/apis.py

+                    continue
+                file_paths = old_tags_info[tag_name]
+                destination_tags_info[tag_id] = file_paths
+            for tag_name, tag_id in old_exist_tags.items():


改成metadata_tag_id

JoinTyang · 2025-05-08T09:42:39Z

seahub/repo_metadata/apis.py

+            record_id = record.get(METADATA_TABLE.columns.id.name)
+
+            file_path = posixpath.join(parent_dir, file_name)
+            file_to_record_map[file_path] = record_id


改成 file_path_to_record_id

JoinTyang · 2025-05-08T09:57:47Z

seahub/repo_metadata/apis.py

+                tag_name = tag.get(TAGS_TABLE.columns.name.name)
+                tags_created[tag_name] = new_tag_id
+
+        return tags_created, old_exist_tags


tags_created, old_exist_tags 这两个的意义是一样的吧，可以合并吧

JoinTyang · 2025-05-09T02:01:05Z

seahub/repo_metadata/apis.py

+            for idx, tag in enumerate(tags_to_create):
+                new_tag_id = new_tag_ids[idx]
+                tag_name = tag.get(TAGS_TABLE.columns.name.name)
+                tags_created_name_to_metadata_tag_id[tag_name] = new_tag_id


这个也用 old_tag_name_to_metadata_tag_id 就可以了，没必要新加一个变量

JoinTyang · 2025-05-09T02:18:17Z

seahub/repo_metadata/apis.py

+
+            old_tags_info[old_tag_name].add(file_path)
+            file_paths_set.add(file_path)
+        return old_tags_info, file_paths_set


old_tags_info 改成 old_tag_name_to_file_paths

JoinTyang · 2025-05-09T02:26:58Z

seahub/repo_metadata/apis.py

+            return api_error(status.HTTP_500_INTERNAL_SERVER_ERROR, error_msg)
+
+        try:
+            destination_tags_info = {}  # {tag_id: file_paths}


destination_tags_info 改成 metadata_tag_id_to_file_paths

JoinTyang · 2025-05-09T02:40:25Z

seahub/repo_metadata/apis.py

+            return api_error(status.HTTP_403_FORBIDDEN, error_msg)
+
+        from seafevents.repo_metadata.constants import TAGS_TABLE
+        from seafevents.repo_metadata.constants import METADATA_TABLE


这两个放到一行

孙永强 added 4 commits April 22, 2025 09:47

tags migrate

b8fe71d

handle exist tag name

optimize code

1118d40

update

5860161

update ui

1b02d7b

JoinTyang reviewed May 6, 2025

View reviewed changes

孙永强 added 5 commits May 7, 2025 10:45

update design

ce08321

optimize sql

38d74dd

update sql

f132411

update

3236b20

update

d420105

JoinTyang reviewed May 7, 2025

View reviewed changes

optimize code

859e06e

JoinTyang reviewed May 8, 2025

View reviewed changes

update

e16bb8c

JoinTyang reviewed May 8, 2025

View reviewed changes

update

fe52665

JoinTyang reviewed May 9, 2025

View reviewed changes

孙永强 added 3 commits May 9, 2025 11:19

optimize sql

60d7d34

optimize

d453bce

update

5f38380

JoinTyang merged commit 77260ba into master May 9, 2025
5 checks passed

JoinTyang deleted the tags-migrate branch May 9, 2025 06:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tags migrate #7755

Tags migrate #7755

Tags migrate #7755

Tags migrate #7755

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment