10000 Issue#739 Always parents created child lifetime scope game object by jonah1nine · Pull Request #760 · hadashiA/VContainer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Issue#739 Always parents created child lifetime scope game object #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

jonah1nine
Copy link

PR to addres this issue: #739

If the parent lifetime scope is the root, parenting the child lifetime scope game object to it would automatically make it "not be destroyed on load" (DontDestroyOnLoad).

This change results in all CreateChild api behave the same with regards to their game object parent/child relationship (previous discrepancy was outlined in the issue linked above).

@hadashiA
Copy link
Owner
hadashiA commented May 6, 2025

ok, thank you very much. Sorry for the late response.

@hadashiA hadashiA merged commit edfaf52 into hadashiA:master May 6, 2025
3 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0