8000 feat(primer-miso): request fullscreen mode when expanding eval window by georgefst · Pull Request #1353 · hackworthltd/primer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(primer-miso): request fullscreen mode when expanding eval window #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(primer-miso): request fullscreen mode when expanding eval window #1353

wants to merge 1 commit into from

Conversation

georgefst
Copy link
Contributor

This is something which I utilised as part of #1350 when testing on mobile. It was handy, for gaining a bit of extra screen space, but it's less of an uncontroversially good idea than those other changes. So I'm just stashing it here as a curiosity to potentially revisit at some point.

  • We should really separate the notions of "eval takes up whole app" and "app is actually fullscreen". Those are conflated here. For the latter we should also handle browser events, i.e. that the user can exit fullscreen without using Primer UI (e.g. esc key, in Firefox at least).
  • The JSaddle code isn't very idiomatic, and has no error handling.
  • In an ideal world, this wouldn't be needed at all, and mobile browsers would just have a generic option for this, like pressing f11 on desktop. To my surprise, only Opera Mini appears to have this, and even there it's clunky.

@georgefst
feat(primer-miso): request fullscreen mode when expanding eval window
033ba88 
Signed-off-by: George Thomas <georgefsthomas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@georgefst
0