Add cacheability information to optimization rules #2698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and move enabling of cacheability here (+add time-dependant FDs here)
… depending on it (this functionality is now part #2600)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want Hyrise to cache query plans that will stay valid over time because using a (logical or physical) plan that becomes invalid could cause wrong results. Plans might turn invalid if they depend on temporary data patterns, like non-permanent UCCs found by the UccDiscoveryPlugin, or on related rules (FDs) based on those patterns.
To avoid this, each optimization rule tells Hyrise whether the resulting plan is safe to store in the cache.
Note: This PR relies on #2599. We could also skip this and only depend on
masterbut then #2600 would become messy because it relies on both cacheability information (this PR) and non-permanent UCCs (#2599).