[Buffer Manager] Add PageID and 8000 Frame primitives for the buffer manager #2618
+667
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweisgut
requested changes
Oct 18, 2023
Bouncner
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Haven't looked at the tests yet.
I have several questions on the atomics. In some cases your code might be absolutely correct but the assumptions are hidden, why some things are safe to do.
And for other occasions, I probably just don't understand what you are doing. Good sign that a clarifying comment might help here. :)
dey4ss
reviewed
Oct 19, 2023
dey4ss
reviewed
Oct 19, 2023
Bouncner
reviewed
Oct 26, 2023
….com:nikriek/hyrise into nikriek/buffer-manager/add-frame-and-page-id
Bouncner
reviewed
Oct 26, 2023
mweisgut
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Mainly minor documantation comments.
Feel free to add yourself to the list of Contributors.
Co-authored-by: Marcel Weisgut <marcel.weisgut@hpi.de>
Co-authored-by: Marcel Weisgut <marcel.weisgut@hpi.de>
Co-authored-by: Marcel Weisgut <marcel.weisgut@hpi.de>
Co-authored-by: Marcel Weisgut <marcel.weisgut@hpi.de>
Co-authored-by: Marcel Weisgut <marcel.weisgut@hpi.de>
Co-authored-by: Marcel Weisgut <marcel.weisgut@hpi.de>
Co-authored-by: Marcel Weisgut <marcel.weisgut@hpi.de>
Co-authored-by: Marcel Weisgut <marcel.weisgut@hpi.de>
….com:nikriek/hyrise into nikriek/buffer-manager/add-frame-and-page-id
mweisgut
reviewed
Oct 26, 2023
Co-authored-by: Marcel Weisgut <marcel.weisgut@hpi.de>
….com:nikriek/hyrise into nikriek/buffer-manager/add-frame-and-page-id
mweisgut
approved these changes
Oct 27, 2023
Bouncner
approved these changes
Oct 27, 2023
Bouncner
reviewed
Oct 27, 2023
This was referenced Jan 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in our discussion #2617, we add the basic primitives for the
PageIDandFrame.PageIDis used for the addressing of pages in a buffer manager.Framestores the state of a page and also helps with synchronization.