Add function prototypes in third-party DB generators #2614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouncner
reviewed
Sep 22, 2023
Co-authored-by: Bouncner <martin+github@boissier.de>
6d44b0c to
3d8ce09
Compare
nikriek
pushed a commit
that referenced
this pull request
Oct 28, 2023
Ensure C2x-compatibility, which clang-16+ warns about.
nikriek
pushed a commit
that referenced
this pull request
Nov 6, 2023
Ensure C2x-compatibility, which clang-16+ warns about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang-16 complained about missing prototypes in the TPC-DS and TPC-H data generators (deprecated in C2x). This PR adds them if necessary. Furthermore, the
experimental/functionalheader is not included anymore in the like matcher. The experimental version is not provided by clang-17 (libc++) anymore, leading to a compilation error (and all CI stages use compilers where the experimental header is not necessary).Includes hyrise-mp/tpcds-kit#1.