[DYOD] Support window function queries #2597 8000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream said that we should create new `Chunk`s that re-use the previous segments (they are stored as shared pointers).
…nctionEvaluator::partition_and_sort()`
…dowFunction::Rank`
…pute_window_function`
Assigning does not work, because `operator[]` returns `AllTypeVariant`, not a reference.
It appears that someone is renaming our column after the operator has executed.
…it uses multiple partition-by columns
This is needed to prevent creating a chunk that has both `ReferenceSegment`s and `ValueSegments`s, as our output column is always represented by `ValueSegment`s.
We now reuse all segments from the input table. If the input table is a reference table, we create a new table with our output value segments and then add reference segments to this new table in our output table.
… Assert for correct rank frame
This adds `_templated_on_execute` so that the input column type and window function are compile time constants the whole time. This way, we don't get template instantiation errors down the line when we resolve types again.
… the `window_function_evaluator` namespace
…e separate steps anyways)
We want to use features that gcc 9 doesn't support. Commands to reproduce: ```sh sed -i 's/gcc-9/gcc-10/g' Jenkinsfile Dockerfile install_dependencies.sh sed -i 's/g++-9/g++-10/g' Jenkinsfile Dockerfile install_dependencies.sh sed -i 's/gcc9/gcc10/g' Jenkinsfile Dockerfile install_dependencies.sh sed -i 's/g++9/g++10/g' Jenkinsfile Dockerfile install_dependencies.sh ```
ClFeSc
reviewed
Aug 9, 2023
src/lib/operators/window_function_evaluator/window_function_evaluator_traits.hpp
Show resolved
Hide resolved
|
As discussed with the supervisors, we will close this PR and open another one later for the final submission. This way, it is easier to browse the code at the point of review. |
10 tasks
phkeese
reviewed
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would recommend starting a review with the header files and then to go top-down, that is, start at
WindowFunctionEvaluator::_on_executeand stepping into the used functions from there. The implementation ofSegmentTreeis independent from the rest of the code, so should be okay to review in parallel. Similarly, the construction of the operator (lqp translation) is also rather boilerplate-y, so you can do it at any time.Todos (not necessarily done before intermediate review):
nullptrchunkspartition_and_sort