Make CI runs more stable #2594
Merged
Make CI runs more stable #2594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouncner
approved these changes
Jul 24, 2023
|
If there was no other load on the CI server, over 200 s for generation is likely to timeout under load. |
|
Hmm, wondering if 200-300s is too much in general. What do you think? |
Sounds good. |
As a timeout or for generation? Think a timeout of 5 min is a long time in general, but we don't set it for most commands, right? |
|
Zünd it. |
nikriek
pushed a commit
that referenced
this pull request
Oct 28, 2023
Fix CI issues with concurrent SSB data generation and `StoredtableNode`'s cached output expressions. Co-authored-by: Bouncner <martin+github@boissier.de>
nikriek
pushed a commit
that referenced
this pull request
Nov 6, 2023
Fix CI issues with concurrent SSB data generation and `StoredtableNode`'s cached output expressions. Co-authored-by: Bouncner <martin+github@boissier.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we encountered many CI issues with SSB tests that called the dbgen in in parallel. This PR moves execution of
hyriseBenchmarkStarSchema_test.pyto an own stage and removes SSB data generation fromhyriseConsole_test.py. Furthermore, an issue with concurrent writes ofStoredtableNode's cached output expressions for cached PQPs has been resolved by @Bouncner.