8000 [DYOD] Team 2 - Sprint 4 by ClFeSc · Pull Request #2579 · hyrise/hyrise · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[DYOD] Team 2 - Sprint 4 #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 4, 2023
Merged

[DYOD] Team 2 - Sprint 4 #2579

merged 7 commits into from
Jul 4, 2023

Conversation

ClFeSc
Copy link
Contributor
@ClFeSc ClFeSc commented Jun 14, 2023

No description provided.

@ClFeSc ClFeSc added the FullCI Run all CI tests (slow, but required for merge) label Jun 14, 2023
dey4ss
dey4ss reviewed Jun 15, 2023
View reviewed changes
@dey4ss
Copy link
Member
dey4ss commented Jun 15, 2023

Nice catches, but I have a few comments

10000
@ClFeSc ClFeSc requested a review from dey4ss June 28, 2023 15:33
Bouncner
Bouncner reviewed Jun 28, 2023
View reviewed changes
dey4ss
dey4ss reviewed Jun 30, 2023
View reviewed changes
Bouncner
Bouncner approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator
@Bouncner Bouncner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Bouncner Bouncner merged commit 59fc081 into hyrise:master Jul 4, 2023
@Bouncner Bouncner mentioned this pull request Jul 14, 2023
Merged
nikriek pushed a commit that referenced this pull request Oct 28, 2023
@ClFeSc @nikriek
[DYOD] Team 2 - Sprint 4 (#2579)
a4eef99 
Add tests for table and dummy table node.
nikriek pushed a commit that referenced this pull request Nov 6, 2023
@ClFeSc @nikriek
[DYOD] Team 2 - Sprint 4 (#2579)
ed66fd2 
Add tests for table and dummy table node.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dey4ss dey4ss dey4ss left review comments

@Bouncner Bouncner Bouncner approved these changes

Assignees

@phkeese phkeese

@ClFeSc ClFeSc

@23mafi 23mafi

Labels
FullCI Run all CI tests (slow, but required for merge)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ClFeSc @dey4ss @Bouncner @phkeese @23mafi
0