8000 remove glog dependency by jhawk28 · Pull Request #350 · hypermodeinc/ristretto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove glog dependency #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

jhawk28
Copy link
Contributor
@jhawk28 jhawk28 commented Aug 30, 2023

updated go mod deps

glog adds global flags so it is not a good library (adding to an existing program causes a panic if a flag name conflicts)

@mholt
Copy link
mholt commented Aug 30, 2023

Thank you for making this 🙏

@mangalaman93 mangalaman93 merged commit bdcf5e9 into hypermodeinc:main Aug 30, 2023
@mangalaman93
Copy link
Member

Thanks for updating the PR. Merged.

@jackcipher
Copy link

Hi maintainers,

I noticed that pull request #350 was merged yesterday, but a new tag has not been released yet.Without a new tag, I can't update my go mod.Would you please release a new tag?

@mholt
Copy link
mholt commented Aug 31, 2023

@jackcipher FYI you can always do go get <module>@<commit> even if there is not a tag yet 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0