8000 Pull in fix from FireFly common for openapi JSONAny schema type by EnriqueL8 · Pull Request #1682 · hyperledger/firefly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Pull in fix from FireFly common for openapi JSONAny schema type #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 2, 2025
Merged

Pull in fix from FireFly common for openapi JSONAny schema type #1682

merged 4 commits into from
May 2, 2025

Conversation

EnriqueL8
Copy link
Contributor
@EnriqueL8 EnriqueL8 commented May 1, 2025 •
edited
Loading

Proposed changes

Fixes an issue with the Swagger JSONAny Schema Type

Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Screenshots (If Applicable)

Other Information

Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.

@EnriqueL8
Pull in fix from FireFly common for openapi JSONAny schema type
c48427d 
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
@EnriqueL8 EnriqueL8 requested a review from a team as a code owner May 1, 2025 12:53
This was referenced May 1, 2025
Closed
Open
EnriqueL8 added 3 commits May 1, 2025 17:41
@EnriqueL8
Update FF Common to 1.5.3
ae14ee2 
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
@EnriqueL8
Update FireFly Common to 1.5.4
db032f6 
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
@EnriqueL8
Updated Swagger
c389b2a 
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
@codecov Codecov
Copy link
codecov bot commented May 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (36b4179) to head (c389b2a).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1682   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         339      339           
  Lines       29782    29782           
=======================================
  Hits        29770    29770           
  Misses          8        8           
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EnriqueL8 EnriqueL8 merged commit 09d29f8 into main May 2, 2025
19 checks passed
@EnriqueL8 EnriqueL8 deleted the fix_swagger branch May 2, 2025 12:38
@ssmirr ssmirr mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awrichar awrichar awrichar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EnriqueL8 @awrichar
0