Update ethereum/tests submodule to v16.0 for Prague support #8648
Conversation
|
Thanks for picking this up @markopiers! Please check out this page to sort out the DCO issue Basically just need to sign off your commit with name and email. Can force push to your branch to fix CI. |
Signed-off-by: Marko Piers <markopiers8@gmail.com>
351e502 to
91eb0b3
Compare
|
@siladu thanks. I've fixed the DCO issue now by adding the sign-off to my commit. If everything looks good, I'd appreciate your review and merge of this PR. Looking forward to contributing more to Besu in the future. |
|
@markopiers after running CI, it looks like there are some failures in the reference tests: You can run locally with |
this PR updates the ethereum/tests submodule from the current version to v16.0 as an incremental step toward eventually supporting v17.0.
Changes
updated ethereum/tests submodule to v16.0 (commit hash:
afed83bf2a097cba688a60246429f3a051fe03f6)updated the expectedHash in ethereum/referencetests/build.gradle to match
as noted in issue, v17.0 involves a significant refactor that breaks compatibility with Besu in several ways. 8000 this PR takes the recommended approach of first upgrading to v16.0 to add Prague support without introducing the breaking changes from v17.0. a future PR will be needed to update to v17.0 after addressing the compatibility issues with the refactored test suite.
Testing
verified that the submodule points to the correct v16.0 tag
ensured the expectedHash value in build.gradle matches the v16.0 commit hash
#8558