Fix: javax.inject:javax.inject:1 entry in BOM #8443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a constraint on a version and not a transitive dependency to another BOM/platform. If a Gradle projects depends on both `javax.inject:javax.inject` and `besu`, you currently can run into an error like this: Cannot select module with conflict on capability '...' also provided by [javax.inject:javax.inject:1(platform-compile), javax.inject:javax.inject:1(compile)] Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
fab-10
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This is a constraint on a version and not a transitive dependency to another BOM/platform. If a Gradle projects depends on both
javax.inject:javax.injectandbesu, you currently can run into an error like this:https://scans.gradle.com/s/f237bkq632kb4/failure#1
Fixed Issue(s)
Discovered in hiero-ledger/hiero-gradle-conventions#136
Thanks for sending a pull request! Have you done the following?
[ ] Considered documentation and added thedoc-change-requiredlabel to this PR if updates are required.[ ] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility testsLocally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests