Move mail link service to core #7509
Conversation
| @@ -39,6 +39,7 @@ | |||
| <?= $form->field($model, 'blockUsers')->checkbox() ?> | |||
| <?= $form->field($model, 'hideOnlineStatus')->checkbox() ?> | |||
| <?= $form->field($model, 'allowUserTopics')->checkbox(['data' => ['action-change' => 'admin.space.restrictTopicCreation']]) ?> | |||
| <?= $form->field($model, 'disableChoicesIos')->checkbox() ?> | |||
There was a problem hiding this comment.
@marc-farre Do we still need this option? At least we should move it somewhere into the config file?
There was a problem hiding this comment.
Yes, we do need it, until we provide Apple authentication.
But I agree, we could move it to the config file.
There was a problem hiding this comment.
@yurabakhtin No need to migrate, because I know the HumHub instance that is using it (it's for white label mobile app only).
There was a problem hiding this comment.
Yes, we do need it, until we provide Apple authentication. But I agree, we could move it to the config file.
If it helps HumHub you can always improve @GreenMeteor's OAuth clients as needed as we do provide a number of different ones;
https://github.com/GreenMeteor/humhub-oauth/blob/master/oauth/Apple/Apple.php
There was a problem hiding this comment.
@ArchBlood very interesting. Have you successfully tested it?
There was a problem hiding this comment.
@yurabakhtin A simple param in the humhub block is fine for now.
There was a problem hiding this comment.
@ArchBlood very interesting. Have you successfully tested it?
The person we had testing hasn't responded in sometime now but should be in working order. 🤔
What kind of change does this PR introduce? (check at least one)
The PR fulfills these requirements:
developbranch, not themasterbranch if no hotfixOther information:
https://github.com/humhub/humhub-internal/issues/617