8000 Single warning for holes. by Narsil · Pull Request #1303 · huggingface/tokenizers · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Single warning for holes. #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2023
Merged

Single warning for holes. #1303

merged 2 commits into from
Jul 25, 2023

Conversation

Narsil
Copy link
Collaborator
@Narsil Narsil commented Jul 25, 2023 •
edited
Loading

Fixes #1298

@Narsil Narsil requested a review from ArthurZucker July 25, 2023 10:42
ArthurZucker
ArthurZucker approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator
@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the addition! Do we have an option to de-activate logs/warnings like LOGGING_INFO?

@Narsil
Copy link
Collaborator Author
Narsil commented Jul 25, 2023

No and there won't be as mentionned in the issue. This is a hard error, and is not treated as such only because of old existing tokenizers we cannot modify.

@Narsil Narsil merged commit bb38f39 into main Jul 25, 2023
@Narsil Narsil deleted the hole_single_warning branch July 25, 2023 10:57
8000
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is there a way to supress this warning?
3 participants
@Narsil @HuggingFaceDocBuilderDev @ArthurZucker
0