8000 Updating code according to clippy. by Narsil · Pull Request #1048 · huggingface/tokenizers · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Updating code according to clippy. #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2022
Merged

Updating code according to clippy. #1048

merged 1 commit into from
Aug 24, 2022

Conversation

Narsil
Copy link
Collaborator
@Narsil Narsil commented Aug 23, 2022
  • Adding Eq where possible
  • Denied the ref deref warnings as it was spamming and solution not
    really better.

@Narsil
Updating code according to clippy.
06c71d0 
- Adding `Eq` where possible
- Denied the ref deref warnings as it was spamming and solution not
  really better.
@Narsil Narsil mentioned this pull request Aug 23, 2022
Merged
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

mishig25
mishig25 approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor
@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

What does it mean when #[derive(PartialEq, Eq)] both PartialEq & Eq are present? Shouldn't they be mutually exclusive, like if you have Eq, what is the point of having PartialEq as well?

@Narsil
Copy link
Collaborator Author
Narsil commented Aug 24, 2022

@mishig25 ,

It's actually a cargo clippy warning now. If your are PartialEq and all your members are Eq then you can be Eq. But not every structure can be Eq: https://users.rust-lang.org/t/what-is-the-difference-between-eq-and-partialeq/15751

@Narsil Narsil merged commit b1c9bc6 into main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishig25 mishig25 mishig25 approved these changes

@thomasw21 thomasw21 Awaiting requested review from thomasw21

@McPatate McPatate Awaiting requested review from McPatate

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Narsil @HuggingFaceDocBuilderDev @mishig25
0