New InferenceClient endpoint type
#1813
Draft
+1,068
−284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
reviewed
May 6, 2025
| } | ||
|
|
||
| export const endpointHfInferenceParametersSchema = z.object({ | ||
| type: z.literal("hfinference"), |
There was a problem hiding this comment.
i would name it either inference-providers (the name of the product) or InferenceClient (the name of the library class)
There was a problem hiding this comment.
otherwise it's confusing with provider="hf-inference"
julien-c
reviewed
May 6, 2025
| endpointHfInferenceParametersSchema.parse(input); | ||
|
|
||
| const client = baseURL | ||
| ? new InferenceClient(config.HF_TOKEN).endpoint(baseURL) |
There was a problem hiding this comment.
Suggested change
| ? new InferenceClient(config.HF_TOKEN).endpoint(baseURL) | |
| ? new InferenceClient(config.HF_TOKEN, { endpointUrl: baseURL }) |
julien-c
reviewed
May 6, 2025
src/lib/server/models.ts
Outdated
| @@ -380,6 +306,8 @@ const addEndpoint = (m: Awaited<ReturnType<typeof processModel>>) => ({ | |||
| return endpoints.tgi(args); | |||
| case "local": | |||
| return endpoints.local(args); | |||
| case "hfinference": | |||
There was a problem hiding this comment.
Suggested change
| case "hfinference": | |
| case "inference-providers": |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4D0D
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will become the default endpoint type. It already lets us enable tool calling on a lot of models where we didn't have it before.
Making sure everything works for all the prod models and switching to it in this PR.