10000 Add side and start_side Parameters to Create Review Comment by gilday · Pull Request #2072 · hub4j/github-api · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add side and start_side Parameters to Create Review Comment #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 25, 2025
Merged

Add side and start_side Parameters to Create Review Comment #2072

merged 4 commits into from
Mar 25, 2025

Conversation

gilday
Copy link
Contributor
@gilday gilday commented Mar 24, 2025 •
edited
Loading

Description

Follows existing pattern from line and start_line.

https://docs.github.com/en/rest/pulls/comments?apiVersion=2022-11-28#create-a-review-comment-for-a-pull-request

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is 8000 not a particular common scenario."
  • Enable "Allow edits from maintainers".

@gilday
Add side and start_side Parameters to Create Review Comment
b57a079 
Follows existing pattern from line and start_line
@gilday gilday force-pushed the feat/add-side-parameters branch from f959ac1 to b57a079 Compare March 24, 2025 21:17
@gilday
Copy link
Contributor Author
gilday commented Mar 24, 2025

Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

I lack access needed to run this.

@codecov Codecov
Copy link
codecov bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.84%. Comparing base (91a8ff3) to head (1a86682).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2072      +/-   ##
============================================
+ Coverage     83.83%   83.84%   +0.01%     
- Complexity     2412     2414       +2     
============================================
  Files           236      236              
  Lines          7324     7330       +6     
  Branches        389      389              
============================================
+ Hits           6140     6146       +6     
  Misses          952      952              
  Partials        232      232

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gilday gilday marked this pull request as ready for review March 24, 2025 22:38
bitwiseman
bitwiseman approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member
@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@bitwiseman bitwiseman merged commit 1225510 into hub4j:main Mar 25, 2025
12 checks passed
@gilday gilday deleted the feat/add-side-parameters branch March 26, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman bitwiseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilday @bitwiseman
0