methods for listing PRs where the commit is head & listing branches which contain the commit #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4efc71 to
1559fc9
Compare
|
@tginiotis-at-work |
3788ba2 to
6ee78e9
Compare
|
@bitwiseman is the PR alright now? |
555fa69 to
70343c5
Compare
bitwiseman
requested changes
Aug 13, 2020
There was a problem hiding this comment.
This a good start for testing.
Please create a test scenarios where
- a commit is part of multiple PRs (at least 2).
- a commit is part of no PRs.
- a commit is the head of multiple branches
- a commit is the head of no branches.
I've invited you to hub4j-test-org. You can create a custom repository in that org that is configured exactly how you need it to create the tests you need.
Or you can write code that sets up a temp repository and creates the structure you need using automation. See other parts of this file or some the methods in GHPullRequestTest. But this may be more difficult, it is up to you which you'd rather do.
…hich contain the commit
70343c5 to
8b2a3e1
Compare
|
I have added the 4 additional test cases & implemented the suggestions. Is there anything more than needs attention? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Methods for listing PRs where the commit is head & listing branches which contain the commit.
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn clean compilelocally. This may reformat your code, commit those changes.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.When creating a PR: