Fixes #99 by adding --resolve argument support #657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #99 (just added for the dynamic linking effect) |
aztlan2k
reviewed
Feb 28, 2018
| """ | ||
| self.entries = {} | ||
| for entry in resolve: | ||
| host, port, addresses = entry.split(':', 2) |
There was a problem hiding this comment.
it seems that this won't work correctly if you specify an address without a port. (e.g. www.foo.com:127.0.01) Since this address will end up as the port in this case.
| def test_resolve_ipv4(self): | ||
| with MockHTTPServer(4) as mock_http_server: | ||
| r = http('http://httpbin.org:%s/' % mock_http_server.port, | ||
| '--resolve', 'httpbin.org:%s:%s' % (mock_http_server.port, mock_http_server.host)) |
There was a problem hiding this comment.
as far as I can tell you never test not specifying a PORT when calling --resolve. (--resolve www.foo.com:127.0.0.1)
|
wait a minute... this change is based on a really old version of httpie (c. 2012 - pre-v0.2.6) current master |
|
-I've based it atop of master branch. Any suggestions?-
Sorry, I've used an outdated repo version. Will rebase atop of master.
2018-03-01 0:48 GMT+09:00 Ricardo Contreras <notifications@github.com>:
… wait a minute... this change is based on a really old version of httpie
(c. 2012 - pre-v0.2.6) current master __main__.py looks nothing like that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#657 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMbNCk96swBum80dj0Fcyuw1ZpmNFwyks5tZXVKgaJpZM4SWQic>
.
--
Vladimir Berkutov
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've tried to add
--resolveargument with a support for both IPv4 and IPv6. I would appreciate any comments:)