8000 #573 Handle nonclass Scala types and add tests by jarrodcodes · Pull Request #574 · http4s/rho · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

#573 Handle nonclass Scala types and add tests #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2021
Merged

#573 Handle nonclass Scala types and add tests #574

merged 2 commits into from
Aug 3, 2021

Conversation

jarrodcodes
Copy link
@jarrodcodes jarrodcodes commented Jul 27, 2021 •
edited
Loading

This fixes #573. All tests + 2 new ones are passing.

@jarrodcodes jarrodcodes changed the title Handle nonclass Scala types and add tests #573 Handle nonclass Scala types and add tests Jul 27, 2021
zarthross
zarthross approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member
@zarthross zarthross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

< 8000 div class="pr-review-reactions">
@zarthross zarthross merged commit 902cd60 into http4s:main Aug 3, 2021
@jarrodcodes jarrodcodes deleted the support-nonclass-types branch August 3, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarthross zarthross zarthross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-class Scala types break TypeBuilder
2 participants
@jarrodcodes @zarthross
0