Add Path.flatMapOperations to make editing Path more convenient #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarthross
reviewed
May 11, 2020
| @@ -254,6 +254,17 @@ object models { | |||
| vendorExtensions.foreach { case (key, value) => p.setVendorExtension(key, value) } | |||
| p | |||
| } | |||
|
|
|||
| def flatMapOperations(f: Operation => Option[Operation]): Path = | |||
There was a problem hiding this comment.
Not opposed to putting in this code, but naming wise, I think flat map is not appropriate. This is probably more akin to a collect ?
There was a problem hiding this comment.
collestSome maybe? The signature is more similar to collestFirstSome or collectFoldSome than to collect/collectFirst/collectFold which all take a PartialFunction as an argument.
There was a problem hiding this comment.
Yeah, collectSomeOperations ? It's wordy but I think captures better than flatMap here.
zarthross
approved these changes
Nov 1, 2020
|
Release in https://github.com/http4s/rho/releases/tag/v0.21.0-RC2 should be rolling out to mvn central now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.