8000 DataTable: changing size of cells does not work in every situation by stephanpelikan · Pull Request #7294 · grommet/grommet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

DataTable: changing size of cells does not work in every situation #7294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DataTable: changing size of cells does not work in every situation #7294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d387ce6
Replace calculating table height by CSS solution (#7177)
stephanpelikan Oct 23, 2024
d35561d
Update test snapshots (#7177)
stephanpelikan Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,222 changes: 666 additions & 556 deletions src/js/components/Data/__tests__/__snapshots__/Data-test.tsx.snap
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 14 additions & 8 deletions src/js/components/DataFilters/__tests__/__snapshots__/DataFilters-test.tsx.snap
View file
Open in desktop
10000
Original file line number Diff line number Diff line change
Expand Up @@ -3957,7 +3957,7 @@ exports[`DataFilters sub objects 1`] = `
line-height: 24px;
}

.c36 {
.c37 {
font-size: 18px;
line-height: 24px;
font-weight: bold;
Expand Down Expand Up @@ -4085,6 +4085,7 @@ exports[`DataFilters sub objects 1`] = `
padding: 0;
font-weight: inherit;
text-align: inherit;
height: max-content;
text-align: start;
border-bottom: solid 1px rgba(0, 0, 0, 0.33);
padding-left: 12px;
Expand All @@ -4093,18 +4094,23 @@ exports[`DataFilters sub objects 1`] = `
padding-bottom: 6px;
}

.c35 {
.c36 {
margin: 0;
padding: 0;
font-weight: inherit;
text-align: inherit;
height: max-content;
text-align: start;
padding-left: 12px;
padding-right: 12px;
padding-top: 6px;
padding-bottom: 6px;
}

.c34 {
height: 100%;
}

.c29 {
border-spacing: 0;
border-collapse: collapse;
Expand All @@ -4117,11 +4123,11 @@ exports[`DataFilters sub objects 1`] = `
border-collapse: separate;
}

.c34:focus {
.c35:focus {
outline: 2px solid #6FFFB0;
}

.c34:focus:not(:focus-visible) {
.c35:focus:not(:focus-visible) {
outline: none;
}

Expand Down Expand Up @@ -4425,27 +4431,27 @@ exports[`DataFilters sub objects 1`] = `
</tr>
</thead>
<tbody
class="StyledTable__StyledTableBody-sc-1m3u5g-3 c34"
class="c34 c35"
>
<tr
class="StyledTable__StyledTableRow-sc-1m3u5g-2 "
>
<th
class="c35 "
class="c36 "
scope="row"
>
<div
class="c8"
>
<span
class="c36"
class="c37"
>
Paris
</span>
</div>
</th>
<td
class="c35 "
class="c36 "
>
<div
class="c8"
Expand Down
Loading
0