Feat: Build schema from prebuild PgCatalog #306
Conversation
This enables the usage of a prebuild PgCatalog e.g. on AWS Lambda #301
There was a problem hiding this comment.
This looks good to me. It’s a small change, but I can easily see the benefit. I don’t think it needs tests, in this case the type system should be sufficient enough for our tests.
I just made one small change where I renamed the schema variable to schemaOrCatalog to more accurately reflect the type.
I won’t merge this yet so that other people get a chance to comment. I’ll probably publish it with #305
|
Sounds good to me. |
There was a problem hiding this comment.
LGTM; for anyone else reviewing remember you can ignore whitespace with ?w=1, e.g.:
https://github.com/calebmer/postgraphql/pull/306/files?w=1
My only concern is that instanceof may fail under some circumstances (e.g. mis-matched versions?) and thus do weird things. Should we add an assert to ensure schemas is an array of strings? (I assume declaring it as such isn't sufficient.)
* Feat: Build schema from prebuild PgCatalog This enables the usage of a prebuild PgCatalog e.g. on AWS Lambda graphile#301 * Fixed linting * rename to schemaOrCatalog to reflect type
This enables the usage of a prebuild PgCatalog e.g. on AWS Lambda (#301)