[Bugfix] Fix search by trace id and span id #5331
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cab03a to
0cebcd1
Compare
0cebcd1 to
0a419f3
Compare
| }) | ||
|
|
||
| t.Run(fmt.Sprintf("%s: include span id", v.Version()), func(t *testing.T) { | ||
| spanID := "0000000000010203" |
There was a problem hiding this comment.
Do we need to support search with trimmed leading zeros, e.g. {span:id = "10203"} ?
0a419f3 to
a4a7a1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
{trace_id!="abc"}.{span:id != "0123456789abcdef"}.link:spanID. The bug was hidden because withbytes.TrimLeft(id, "\x00")results afterHexStringToTraceIDandHexStringToSpanIDwere the sameThe ids are stored with leading zeros, no need to trim
Which issue(s) this PR fixes:
Fixes #4437 and #4967
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]