8000 Service Graph: Change expiration counter logic by joe-elliott · Pull Request #5319 · grafana/tempo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Service Graph: Change expiration counter logic #5319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2025
Merged

Service Graph: Change expiration counter logic #5319

merged 3 commits into from
Jun 24, 2025

Conversation

joe-elliott
Copy link
Collaborator

What this PR does:
Changes what we count as an "expired" edge. Currently we use queries like the following to determine what percentage of edges are completed. However this query incorrectly counts edges that use virtual nodes, peer attributes or are root spans against the %age matched.

This PR changes the definition of "expired edge" to only include those edges that are expired and have no matching information to generate a service graph edge.

1 -
sum(
  rate(tempo_metrics_generator_processor_service_graphs_expired_edges{}[$__rate_interval])
)
/
sum(
  rate(tempo_metrics_generator_processor_service_graphs_edges{}[$__rate_interval])
)

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@joe-elliott
change expiration logic 8000
32f8484 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
changelog
ffcbc70 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
unit test
bc24b2e 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott merged commit 7853a76 into grafana:main Jun 24, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapno mapno mapno approved these changes

@mdisibio mdisibio Awaiting requested review from mdisibio mdisibio is a code owner

@yvrhdn yvrhdn Awaiting requested review from yvrhdn yvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

@javiermolinar javiermolinar Awaiting requested review from javiermolinar javiermolinar is a code owner

@carles-grafana carles-grafana Awaiting requested review from carles-grafana carles-grafana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-elliott @mapno
0