8000 Update helm steps for metamonitoring by mattdurham · Pull Request #5292 · grafana/tempo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update helm steps for metamonitoring #5292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mattdurham
Copy link
Contributor

Add metamonitoring information.

@knylander-grafana knylander-grafana added the type/docs Improvements or additions to documentation label Jun 16, 2025
@knylander-grafana
Copy link
Contributor

@mattdurham Let me know when you want me to look at this.

@mattdurham
Copy link
Contributor Author
mattdurham commented Jun 16, 2025

@knylander-grafana give it a loo! ahem look

@mattdurham
Copy link
Contributor Author

Very similar to the GET doc

## Set up metamonitoring

Metamonitoring provides observability for your Tempo deployment by collecting metrics and logs from the Tempo components themselves. This helps you monitor the health and performance of your tracing infrastructure.

Copy link
Contributor
@knylander-grafana knylander-grafana Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone is coming into this procedure, are they going to know what the k8s-monitoring configuration refers to? Is this a reference to the k8s Helm chart? We should provide some context here.

If this is the case, then we should add a sentence or two before the procedure to explain that this section uses a different Helm chart to set up monitoring. Is it related to this Helm chart? https://grafana.com/docs/grafana-cloud/monitor-infrastructure/kubernetes-monitoring/configuration/helm-chart-config/helm-chart/

Also, we should point people to where to set up monitoring for GET since you've separated the procedures into two locations.

Are these steps very similar? If so, we're going to have to either maintain two separate procedures or we should consider sharing the content from one repository to the other.

For example:

Suggested change
Setting up metamonitoring for Tempo and GET uses the `k8s-monitoring` Helm chart.
For more information about this Helm chart, refer to [k8s-monitoring README](https://github.com/grafana/k8s-monitoring-helm/blob/main/charts/k8s-monitoring/README.md).

Metamonitoring provides observability for your Tempo deployment by collecting metrics and logs from the Tempo components themselves. This helps you monitor the health and performance of your tracing infrastructure.

### Configure metamonitoring

Copy link
Contributor
@knylander-grafana knylander-grafana Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence adds some context for what the procedure does, especially since it references a different Helm chart. A

Suggested change
To configure metamonitoring, you need to create a `metamonitoring-values.yaml` file and use the k8s-monitoring Helm chart.


### Configure metamonitoring

1. Create a `metamonitoring-values.yaml` file for the k8s-monitoring configuration:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the official name kubernetes-monitoring or k8s-monitoring? We should use the correct name.

enabled: true # This will send Grafana Alloy metrics to ensure the monitoring is working properly.
```

Replace the following values with your monitoring backend details:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

Consider moving this to before the example. Otherwise, people might copy and paste the file and miss that they have to change items.

Comment on lines +723 to +724
- Go to **Explore** > **Prometheus**
- Query for Tempo metrics like `tempo_build_info` or `tempo_distributor_spans_received_total`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Go to **Explore** > **Prometheus**
- Query for Tempo metrics like `tempo_build_info` or `tempo_distributor_spans_received_total`
- Go to **Explore** > **Prometheus**.
- Query for Tempo metrics like `tempo_build_info` or `tempo_distributor_spans_received_total`.

@knylander-grafana
Copy link
Contributor

Matt, ping me when you want me to re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0